Page MenuHomeFreeBSD

amd64: Ignore 1GB mappings in pmap_advise()
ClosedPublic

Authored by markj on Sep 22 2022, 11:08 PM.
Tags
None
Referenced Files
F97459870: D36675.diff
Sun, Sep 29, 12:27 PM
Unknown Object (File)
Tue, Sep 24, 7:20 PM
Unknown Object (File)
Sun, Sep 22, 11:17 AM
Unknown Object (File)
Sun, Sep 22, 6:42 AM
Unknown Object (File)
Mon, Sep 2, 5:41 PM
Unknown Object (File)
Aug 21 2024, 12:21 AM
Unknown Object (File)
Aug 20 2024, 8:23 PM
Unknown Object (File)
Aug 17 2024, 10:25 PM
Subscribers

Details

Summary

This assertion can be triggered by usermode since vm_map_madvise()
doesn't force advice to be applied to an entire largepage mapping. I
can't see any reason not to permit it, however, since MADV_DONTNEED and
_FREE are advisory and we can simply do nothing when a 1GB mapping is
encountered.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 47498
Build 44385: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 22 2022, 11:53 PM

Shouldn't the same change be made on arm64?

This revision was automatically updated to reflect the committed changes.
In D36675#832960, @alc wrote:

Shouldn't the same change be made on arm64?

Yes, I committed it as a follow-up.