smbfs: add deprecation notice
Needs ReviewPublic
Actions

Authored by emaste on Oct 28 2021, 1:59 PM.

Details

Reviewers

allanjude
brooks

Summary

Will update smbutil.1 and mount_smbfs.8 as well, if we're happy with the wording and plan.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Oct 28 2021, 1:59 PM

emaste created this revision.

emaste added inline comments.

share/man/man5/smbfs.5
48	Perhaps This filesystem driver supports only the obsolete SMBv1 protocol. It, along with its userspace...

Should we add some warning printf upon programs invocation too ?

Should we add some warning printf upon programs invocation too ?

Not a bad idea, probably just a warnx() in mount_smbfs

emaste added inline comments.Oct 28 2021, 2:06 PM

share/man/man5/smbfs.5
55	sigh, evaluate

emaste updated this revision to Diff 97611.Oct 28 2021, 2:10 PM

Reviewed by: allanjude

This revision is now accepted and ready to land.Oct 28 2021, 2:54 PM

Seems fine. Does it make sense to add a gone_in to the mount code in the kernel?

Add gone_in and add note to smbutil.1 and mout_smbfs.8 also

This revision now requires review to proceed.Oct 28 2021, 3:33 PM

Does it make sense to add a gone_in to the mount code in the kernel?

Yeah, a kernel gone_in is probably the right place (rather than the userland utilities as previously mentioned)

A number of people on the mailing list reported they are still using it. Perhaps this deprecation warning instead:

The smbfs filesystem driver supports only the obsolete SMBv1 protocol.
smbfs is currently unmaintained and may not function correctly in 
FreeBSD 14 or later.  Users are advised to evaluate the 
sysutils/fusefs-smbnetfs port instead.

Added a caution statement in 7c140ef034c33ab0b16b535f3d5f945dc8f71cb4; this review stalled as there are actually still some smbfs users. I still expect to go ahead with deprecation/removal after further discussion/time for migration.