Differential D31920

bsd.lib.mk: add conditions for building _pie.a archives
ClosedPublic
Actions

Authored by emaste on Sep 12 2021, 4:58 PM.

Details

Reviewers

Commits

rG95ea87898f23: bsd.lib.mk: add conditions for building _pie.a archives
rGa2e4c22a0e1a: bsd.lib.mk: add conditions for building _pie.a archives
rG7c0226cad3f3: bsd.lib.mk: add conditions for building _pie.a archives

Summary

As with other .a targets, build _pie.a archives only if LIB is set.

At present we build _pie.a only for INTERNALLIBs, and none of them include bsd.lib.mk without setting LIB. However, one of these conditions may change in the future.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Sep 12 2021, 4:58 PM

Herald added a subscriber: bdrewery. · View Herald TranscriptSep 12 2021, 4:58 PM

emaste requested review of this revision.Sep 12 2021, 4:58 PM

Seems reasonable to me. What is the motivating use case?

This revision is now accepted and ready to land.Sep 13 2021, 9:13 AM

I have a local change to build _pie also for !INTERNALLIB with an end goal of supporting PIE builds for software out of the base system linking against .a archives.

Closed by commit rG7c0226cad3f3: bsd.lib.mk: add conditions for building _pie.a archives (authored by emaste). · Explain WhySep 13 2021, 11:53 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG7c0226cad3f3: bsd.lib.mk: add conditions for building _pie.a archives.

emaste added a commit: rGa2e4c22a0e1a: bsd.lib.mk: add conditions for building _pie.a archives.Sep 20 2021, 12:32 AM

emaste added a commit: rG95ea87898f23: bsd.lib.mk: add conditions for building _pie.a archives.