Page MenuHomeFreeBSD
Differential D31449

e1000: Fix lem/em UDP rx csum offload
ClosedPublic
Actions

Authored by kbowling on Aug 7 2021, 4:36 AM.
Tags
None
Referenced Files
F116060239: D31449.id93374.diff
Fri, May 2, 5:17 AM
Unknown Object (File)
Mon, Apr 21, 10:32 PM
Unknown Object (File)
Mon, Apr 21, 4:17 AM
Unknown Object (File)
Wed, Apr 16, 3:30 AM
Unknown Object (File)
Sun, Apr 13, 4:58 AM
Unknown Object (File)
Mar 16 2025, 11:18 PM
Unknown Object (File)
Mar 5 2025, 4:24 PM
Unknown Object (File)
Feb 23 2025, 7:41 PM
View All 96 Files
Subscribers
grehan
• karels

Details

Reviewers
emaste
scottl
grehan
Group Reviewers
Intel Networking
Commits
rGec56aaca91b2: e1000: Fix lem/em UDP rx csum offload
rG0d0726a769a1: e1000: Fix lem/em UDP rx csum offload
rG015075f38348: e1000: Fix lem/em UDP rx csum offload
Summary

Rebase on igb code and unify lem/em implementations.

PR: 257642
MFC after: 1 week

Test Plan

Checked lem vs em functionality by datasheet:

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling requested review of this revision.Aug 7 2021, 4:36 AM
kbowling created this revision.
kbowling retitled this revision from e1000: Fix UDP rx checksum offload to e1000: Fix lem/em UDP rx csum offload.Aug 7 2021, 4:38 AM
• karels added a subscriber: • karels.Aug 7 2021, 1:01 PM
• karels added inline comments.
sys/dev/e1000/em_txrx.c
740

Isn't this test redundant?

kbowling updated this revision to Diff 93374.Aug 7 2021, 4:21 PM
kbowling marked an inline comment as done.
kbowling added inline comments.
sys/dev/e1000/em_txrx.c
740

Yes, thanks!

• karels added inline comments.Aug 7 2021, 5:04 PM
sys/dev/e1000/em_txrx.c
740

fwiw, the comment might have been worth keeping.

emaste added inline comments.Aug 7 2021, 5:13 PM
sys/dev/e1000/em_txrx.c
740

Yeah, seems like it

kbowling marked an inline comment as done.Aug 7 2021, 5:49 PM
kbowling added a subscriber: grehan.
kbowling added inline comments.
sys/dev/e1000/em_txrx.c
740

I'm indifferent to it, I'd want to go add it back to igb and igc if it stays here. @grehan thoughts?

grehan accepted this revision.Aug 9 2021, 9:22 PM
This revision is now accepted and ready to land.Aug 9 2021, 9:22 PM
Closed by commit rG015075f38348: e1000: Fix lem/em UDP rx csum offload (authored by Kevin Bowling <kbowling@FreeBSD.org>). · Explain WhyAug 9 2021, 9:33 PM
This revision was automatically updated to reflect the committed changes.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG015075f38348: e1000: Fix lem/em UDP rx csum offload.
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rG0d0726a769a1: e1000: Fix lem/em UDP rx csum offload.Aug 16 2021, 12:58 AM
Kevin Bowling <kbowling@FreeBSD.org> added a commit: rGec56aaca91b2: e1000: Fix lem/em UDP rx csum offload.

Revision Contents
Changeset List

PathSize
sys/
dev/
e1000/
67 lines

Diff 93467

View Options

sys/dev/e1000/em_txrx.c

Loading...