Page MenuHomeFreeBSD

zfs: unbreak stable/13 clang build on i386 after b0c251b0d
ClosedPublic

Authored by mm on Jun 16 2021, 12:50 AM.
Tags
Referenced Files
Unknown Object (File)
Sun, Oct 27, 10:40 PM
Unknown Object (File)
Oct 18 2024, 11:39 AM
Unknown Object (File)
Oct 2 2024, 12:48 AM
Unknown Object (File)
Sep 30 2024, 5:23 AM
Unknown Object (File)
Sep 30 2024, 5:17 AM
Unknown Object (File)
Sep 30 2024, 3:25 AM
Unknown Object (File)
Sep 18 2024, 6:18 AM
Unknown Object (File)
Sep 9 2024, 1:38 PM
Subscribers

Details

Summary

Add missing atomic operations from atomic.c

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mm requested review of this revision.Jun 16 2021, 12:50 AM
mm created this revision.

Aaa... While the patch may be OK, I am surprised that my e76373de7b7384bb6e5c6fd5e04f15b54df20fb7 was merged into zfs-2.1-release before fef8bd41fc178d7212957b611c9bc81fe10cb63e. Merge in proper order would not cause this problem in first place. Do you have a clue why it was not done that way?

I assume Brian just forgot to merge that commit or intentionally didn't merge that commit and did not inspect your commit for changes in that direction. The i386 build should be broken for Linux as well.

Could you ask him to merge the dependency instead of creating unneeded divergence, unless there is a good cause?

I am definitely going to do that. But in the meantime we need a buildable stable/13 for i386. The solution I am proposing does (temporarily) place an additional file into cddl/lib/libspl what is outside of sys/contrib/openzfs.

Actually my original version was written in assembler to be added into atomic.S without using the compiler atomics: https://people.freebsd.org/~mav/zzz3S.patch . I think it would be more consistent with original code. But since it is hopefully temporary, I am fine with any approach.

This revision is now accepted and ready to land.Jun 16 2021, 1:33 AM

I am in for the assembler code patch. I will prepare an updated version.

This revision now requires review to proceed.Jun 16 2021, 1:55 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jun 16 2021, 1:59 AM
This revision was automatically updated to reflect the committed changes.