Page MenuHomeFreeBSD

tcp: When we have an out-of-order FIN we do want to strip off the FIN bit.
ClosedPublic

Authored by rrs on May 27 2021, 12:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 9, 8:35 PM
Unknown Object (File)
Oct 24 2024, 7:26 AM
Unknown Object (File)
Oct 18 2024, 7:39 PM
Unknown Object (File)
Oct 1 2024, 1:13 PM
Unknown Object (File)
Sep 23 2024, 2:41 AM
Unknown Object (File)
Sep 7 2024, 4:36 PM
Unknown Object (File)
Sep 2 2024, 1:03 AM
Unknown Object (File)
Aug 27 2024, 5:34 AM
Subscribers

Details

Summary

The last set of commits fixed both a panic (in rack) and an ACK-war (in freebsd and bbr).
However there was a missing case, i.e. where we get an out-of-order FIN by itself.
In such a case we don't want to leave the FIN bit set, otherwise we will do the
wrong thing and ack the FIN incorrectly. Instead we need to go through the
tcp_reasm() code and that way the FIN will be stripped and all will be well.

Test Plan

We can use the tcp-test-suite with reorder_5F4321.pkt to test this case.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped