Page MenuHomeFreeBSD
Differential D27980

netmap: bridge: fix bridge support for NS_MOREFRAG
ClosedPublic
Actions

Authored by vmaffione on Jan 5 2021, 5:09 PM.
Tags
None
Referenced Files
F98317774: D27980.diff
Thu, Oct 3, 12:27 AM
Unknown Object (File)
Wed, Oct 2, 4:08 PM
Unknown Object (File)
Tue, Oct 1, 6:44 AM
Unknown Object (File)
Tue, Oct 1, 12:17 AM
Unknown Object (File)
Fri, Sep 27, 5:42 PM
Unknown Object (File)
Fri, Sep 27, 6:49 AM
Unknown Object (File)
Fri, Sep 27, 12:12 AM
Unknown Object (File)
Thu, Sep 26, 4:25 PM
View All 42 Files
Subscribers
rajesh1.kumar_amd.com

Details

Reviewers
None
Commits
rGaf352cf1397f: netmap: bridge: fix NS_MOREFRAG support
rG163f4f15733f: netmap: bridge: fix NS_MOREFRAG support
Summary

Support for NS_MOREFRAG is broken, as NS_MOREFRAG is copied from the TX slot to the RX slot rather than the other way around. Also, the NS_MOREFRAG must be copied also in case of packet copy (no zerocopy).

Inspired by:
https://reviews.freebsd.org/D27877

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vmaffione requested review of this revision.Jan 5 2021, 5:09 PM
vmaffione created this revision.
vmaffione mentioned this in D27877: Support for NS_MOREFRAG in Netmap bridge utility.Jan 5 2021, 5:15 PM
vmaffione added a comment.Jan 6 2021, 8:15 PM

@rajesh1.kumar_amd.com
Thanks for testing, I'll push this right away.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 7 2021, 7:07 AM
Closed by commit rG163f4f15733f: netmap: bridge: fix NS_MOREFRAG support (authored by vmaffione). · Explain Why
This revision was automatically updated to reflect the committed changes.
vmaffione added a commit: rG163f4f15733f: netmap: bridge: fix NS_MOREFRAG support.
vmaffione added a commit: rGaf352cf1397f: netmap: bridge: fix NS_MOREFRAG support.Jan 10 2021, 9:11 AM

Revision Contents
Changeset List

PathSize
tools/
tools/
netmap/
12 lines

Diff 81786

View Options

tools/tools/netmap/bridge.c

Loading...